[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] qapi: Document meaning of 'ignore' BlockdevOnError for j
From: |
Kevin Wolf |
Subject: |
Re: [PATCH 1/7] qapi: Document meaning of 'ignore' BlockdevOnError for jobs |
Date: |
Mon, 17 Feb 2020 10:58:17 +0100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
Am 16.02.2020 um 22:44 hat Ján Tomko geschrieben:
> On Fri, Feb 14, 2020 at 09:08:06PM +0100, Kevin Wolf wrote:
> > It is not obvious what 'ignore' actually means for block jobs: It could
> > be continuing the job and returning success in the end despite the error
> > (no block job does this). It could also mean continuing and returning
> > failure in the end (this is what stream does). And it can mean retrying
> > the failed request later (this is what backup, commit and mirror do).
> >
> > This (somewhat inconsistent) behaviour was introduced and described for
> > stream and mirror in commit ae586d6158. backup and commit were
>
> fatal: ambiguous argument 'ae586d6158': unknown revision or path not in the
> working tree.
Oops, thanks for catching this. Not sure how this happened, but
32c81a4a6ec is the correct commit.
Kevin
signature.asc
Description: PGP signature
- [PATCH 0/7] commit: Expose on-error option in QMP, Kevin Wolf, 2020/02/14
- [PATCH 1/7] qapi: Document meaning of 'ignore' BlockdevOnError for jobs, Kevin Wolf, 2020/02/14
- [PATCH 2/7] commit: Remove unused bytes_written, Kevin Wolf, 2020/02/14
- [PATCH 4/7] commit: Inline commit_populate(), Kevin Wolf, 2020/02/14
- [PATCH 3/7] commit: Fix argument order for block_job_error_action(), Kevin Wolf, 2020/02/14
- [PATCH 5/7] commit: Fix is_read for block_job_error_action(), Kevin Wolf, 2020/02/14
- [PATCH 6/7] commit: Expose on-error option in QMP, Kevin Wolf, 2020/02/14