Re: [PATCH v2 26/30] docs/interop: Convert qemu-qmp-ref to rST

[Peter Maydell]

On Thu, 13 Feb 2020 at 17:57, Peter Maydell <address@hidden> wrote:
>
> Convert qemu-qmp-ref to rST format. This includes dropping
> the plain-text, pdf and info format outputs for this document;
> as with all our other Sphinx-based documentation, we provide
> HTML and manpage only.
>
> The qemu-qmp-ref.rst is somewhat more stripped down than
> the .texi was, because we do not (currently) attempt to
> generate indexes for the commands, events and data types
> being documented.
>
> Again, we drop the direct link from index.html.in now that
> the QMP ref is part of the interop manual.
>
> Signed-off-by: Peter Maydell <address@hidden>

This patch is missing this fixup chunk:

diff --git a/Makefile b/Makefile
index 687a17dc0cb..8b719e10a85 100644
--- a/Makefile
+++ b/Makefile
@@ -1046,7 +1046,8 @@ $(MANUAL_BUILDDIR)/system/index.html: $(call
manual-deps,system)

 $(call define-manpage-rule,interop,\
        qemu-ga.8 qemu-ga-ref.7 \
-       qemu-img.1 qemu-nbd.8 qemu-trace-stap.1\
+       qemu-img.1 qemu-nbd.8 \
+       qemu-qmp-ref.7 qemu-trace-stap.1 \
        virtiofsd.1 virtfs-proxy-helper.1,\
        $(SRC_PATH)/qemu-img-cmds.hx $(SRC_PATH)/qga/qapi-schema.json \
        $(qapi-modules) $(qapi-py))

which tells Make how to actually build qemu-qmp-ref.7.
Without this you get build failures doing a build from
clean. (I think I must have accidentally lost this bit
during a rebase, and not noticed because the old .7
file was still hanging around in my tree and incremental
builds worked fine.)

thanks
-- PMM