qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 47/79] m68k/q800: use memdev for RAM


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v5 47/79] m68k/q800: use memdev for RAM
Date: Tue, 18 Feb 2020 08:05:16 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 2/17/20 6:34 PM, Igor Mammedov wrote:
Switch to using generic main RAM allocation. To do this set
MachineClass::default_ram_id to m68k_mac.ram and use
MachineState::ram instead of manually initializing
RAM memory region.

Signed-off-by: Igor Mammedov <address@hidden>
Acked-by: Laurent Vivier <address@hidden>
---
  hw/m68k/q800.c | 6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c
index 1e32363688..a4c4bc14cb 100644
--- a/hw/m68k/q800.c
+++ b/hw/m68k/q800.c
@@ -160,7 +160,6 @@ static void q800_init(MachineState *machine)
      ram_addr_t initrd_base;
      int32_t initrd_size;
      MemoryRegion *rom;
-    MemoryRegion *ram;
      MemoryRegion *io;
      const int io_slice_nb = (IO_SIZE / IO_SLICE) - 1;
      int i;
@@ -194,9 +193,7 @@ static void q800_init(MachineState *machine)
      qemu_register_reset(main_cpu_reset, cpu);
/* RAM */
-    ram = g_malloc(sizeof(*ram));
-    memory_region_init_ram(ram, NULL, "m68k_mac.ram", ram_size, &error_abort);
-    memory_region_add_subregion(get_system_memory(), 0, ram);
+    memory_region_add_subregion(get_system_memory(), 0, machine->ram);
/*
       * Memory from IO_BASE to IO_BASE + IO_SLICE is repeated
@@ -443,6 +440,7 @@ static void q800_machine_class_init(ObjectClass *oc, void 
*data)
      mc->max_cpus = 1;
      mc->is_default = 0;
      mc->block_default_type = IF_SCSI;
+    mc->default_ram_id = "m68k_mac.ram";
  }
static const TypeInfo q800_machine_typeinfo = {


Reviewed-by: Philippe Mathieu-Daudé <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]