Re: [PATCH 00/22] linux-user: generate syscall_nr.sh

[Aleksandar Markovic]

On Tuesday, February 18, 2020, Laurent Vivier <address@hidden> wrote:
> Le 18/02/2020 à 07:13, Philippe Mathieu-Daudé a écrit :
> > On 2/17/20 11:35 PM, Laurent Vivier wrote:
> >> This series copies the files syscall.tbl from linux v5.5 and generates
> >> the file syscall_nr.h from them.
> >>
> > [...]
> >> Laurent Vivier (22):
> >>    linux-user: introduce parameters to generate syscall_nr.h
> >>    linux-user,alpha: add syscall table generation support
> >>    linux-user,hppa: add syscall table generation support
> >>    linux-user,m68k: add syscall table generation support
> >>    linux-user,xtensa: add syscall table generation support
> >>    linux-user,sh4: add syscall table generation support
> >>    linux-user,microblaze: add syscall table generation support
> >>    linux-user,arm: add syscall table generation support
> >>    linux-user,ppc: split syscall_nr.h
> >>    linux-user,ppc: add syscall table generation support
> >>    linux-user,s390x: remove syscall definitions for !TARGET_S390X
> >>    linux-user,s390x: add syscall table generation support
> >>    linux-user,sparc,sparc64: add syscall table generation support
> >>    linux-user,i386: add syscall table generation support
> >>    linux-user,x86_64: add syscall table generation support
> >>    linux-user,mips: add syscall table generation support
> >>    linux-user,mips64: split syscall_nr.h
> >>    linux-user,mips64: add syscall table generation support
> >>    linux-user,scripts: add a script to update syscall.tbl
> >>    linux-user: update syscall.tbl from linux 0bf999f9c5e7
> >>    linux-user,mips: move content of mips_syscall_args
> >>    linux-user,mips: update syscall-args-o32.c.inc
> > 
> > I suppose the patch subject was generated and you meant to use
> > "linux-user/" instead of "linux-user,". Is that right?
> > 
>
> No, the idea is they touch "linux-user" subsystem and "ARCH" subsystem,
> not especially the "linux-user/ARCH" directory

I think Laurent's marks are appropriate, in fact, very useful for these areas of code. Elsewhere,,for example, one could use "softfoat,mips" for changes in softfloat affecting mips only.

Regards,

Aleksandar

 

> Thanks,
> Laurent