Re: [PATCH v2] hw/i386: disable smbus migration for xenfv

[Olaf Hering]

Am Thu, 16 Jan 2020 19:26:39 +0100
schrieb Paolo Bonzini <address@hidden>:

> On 16/01/20 19:03, Olaf Hering wrote:
>  [...]  
> 
> This patch is wrong; xenfv does not support cross-version migration
> compatibility.  Even if the migration stream does not change, the
> hardware exposed to the guest will.
> 
> My understanding is that Xen is able to use "-M
> pc-i440fx-VERSION,accel=xen".  The presence of the version in the
> machine type guarantees that the migration stream is compatible and that
> the hardware exposed to the guest is the same on the source and destination.

The current idea is to make 'xenfv' a copy of 'pc-i440fx-3.1'.
But is this actually the desired behavior?

Lets assume xenfv_machine_options calls pc_i440fx_5_0_machine_options.
What impact that that have on the result of pc_init1()?
Is any of the things done by pc_i440fx_5_0_machine_options and
pc_i440fx_machine_options a desired, or even breaking, change for the
current result of pc_xen_hvm_init?

Also, do the calls to compat_props_add have negative impact on compatibility
for running domUs?

Olaf

pgpnIvrAdZRIv.pgp
Description: Digitale Signatur von OpenPGP