[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 09/13] migrate/ram: Consolidate variable reset after placement
From: |
David Hildenbrand |
Subject: |
[PATCH v1 09/13] migrate/ram: Consolidate variable reset after placement in ram_load_postcopy() |
Date: |
Wed, 19 Feb 2020 17:17:21 +0100 |
Let's consolidate resetting the variables.
Cc: "Dr. David Alan Gilbert" <address@hidden>
Cc: Juan Quintela <address@hidden>
Cc: Peter Xu <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
migration/ram.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 80a4e4a9ea..ab1f5534cf 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -3126,7 +3126,7 @@ static int ram_load_postcopy(QEMUFile *f)
/* Temporary page that is later 'placed' */
void *postcopy_host_page = mis->postcopy_tmp_page;
void *host_page = NULL;
- bool all_zero = false;
+ bool all_zero = true;
int target_pages = 0;
while (!ret && !(flags & RAM_SAVE_FLAG_EOS)) {
@@ -3151,7 +3151,6 @@ static int ram_load_postcopy(QEMUFile *f)
addr &= TARGET_PAGE_MASK;
trace_ram_load_postcopy_loop((uint64_t)addr, flags);
- place_needed = false;
if (flags & (RAM_SAVE_FLAG_ZERO | RAM_SAVE_FLAG_PAGE |
RAM_SAVE_FLAG_COMPRESS_PAGE)) {
block = ram_block_from_stream(f, flags);
@@ -3179,9 +3178,7 @@ static int ram_load_postcopy(QEMUFile *f)
*/
page_buffer = postcopy_host_page +
host_page_offset_from_ram_block_offset(block, addr);
- /* If all TP are zero then we can optimise the place */
if (target_pages == 1) {
- all_zero = true;
host_page = host_page_from_ram_block_offset(block, addr);
} else if (host_page != host_page_from_ram_block_offset(block,
addr)) {
@@ -3198,7 +3195,6 @@ static int ram_load_postcopy(QEMUFile *f)
*/
if (target_pages == (block->page_size / TARGET_PAGE_SIZE)) {
place_needed = true;
- target_pages = 0;
}
}
@@ -3274,6 +3270,10 @@ static int ram_load_postcopy(QEMUFile *f)
ret = postcopy_place_page(mis, host_page, postcopy_host_page,
block);
}
+ place_needed = false;
+ target_pages = 0;
+ /* Assume we have a zero page until we detect something different
*/
+ all_zero = true;
}
}
--
2.24.1
- Re: [PATCH v1 02/13] stubs/ram-block: Remove stubs that are no longer needed, (continued)
- [PATCH v1 03/13] numa: Teach ram block notifiers about resizeable ram blocks, David Hildenbrand, 2020/02/19
- [PATCH v1 04/13] numa: Make all callbacks of ram block notifiers optional, David Hildenbrand, 2020/02/19
- [PATCH v1 06/13] migrate/ram: Discard new RAM when growing RAM blocks and the VM is stopped, David Hildenbrand, 2020/02/19
- [PATCH v1 05/13] migrate/ram: Handle RAM block resizes during precopy, David Hildenbrand, 2020/02/19
- [PATCH v1 08/13] migrate/ram: Simplify host page handling in ram_load_postcopy(), David Hildenbrand, 2020/02/19
- [PATCH v1 09/13] migrate/ram: Consolidate variable reset after placement in ram_load_postcopy(),
David Hildenbrand <=
- [PATCH v1 07/13] migrate/ram: Get rid of "place_source" in ram_load_postcopy(), David Hildenbrand, 2020/02/19
- Re: [PATCH v1 07/13] migrate/ram: Get rid of "place_source" in ram_load_postcopy(), David Hildenbrand, 2020/02/20
- Re: [PATCH v1 07/13] migrate/ram: Get rid of "place_source" in ram_load_postcopy(), Dr. David Alan Gilbert, 2020/02/20
[PATCH v1 10/13] migrate/ram: Handle RAM block resizes during postcopy, David Hildenbrand, 2020/02/19