[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] memory: batch allocate ioeventfds[] in address_space_update_
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH] memory: batch allocate ioeventfds[] in address_space_update_ioeventfds() |
|
Date: |
Wed, 19 Feb 2020 16:45:22 +0000 |
On Wed, Feb 19, 2020 at 12:36:04PM +0100, Paolo Bonzini wrote:
> On 18/02/20 19:22, Stefan Hajnoczi wrote:
> > + * It is likely that the number of ioeventfds hasn't changed much, so
> > use
> > + * the previous size as the starting value.
> > + */
> > + ioeventfd_max = as->ioeventfd_nb;
> > + ioeventfds = g_new(MemoryRegionIoeventfd, ioeventfd_max);
>
> This would be a bit space-inefficient if we are adding just one ioeventfd,
> because it would waste 64 entries right below. I would like to squash this
> if it's okay with you:
Yes, please feel free to squash it:
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature