[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] aspeed/smc: Fix User mode select/unselect scheme
|
From: |
Andrew Jeffery |
|
Subject: |
Re: [PATCH 2/2] aspeed/smc: Fix User mode select/unselect scheme |
|
Date: |
Thu, 20 Feb 2020 14:35:15 +1030 |
|
User-agent: |
Cyrus-JMAP/3.1.7-802-g7a41c81-fmstable-20200203v1 |
On Thu, 6 Feb 2020, at 21:56, Cédric Le Goater wrote:
> The Aspeed SMC Controller can operate in different modes : Read, Fast
> Read, Write and User modes. When the User mode is configured, it
> selects automatically the SPI slave device until the CE_STOP_ACTIVE
> bit is set to 1. When any other modes are configured the device is
> unselected. The HW logic handles the chip select automatically when
> the flash is accessed through its AHB window.
>
> When configuring the CEx Control Register, the User mode logic to
> select and unselect the slave is incorrect and data corruption can be
> seen on machines using two chips, witherspoon and romulus.
>
> Rework the handler setting the CEx Control Register to fix this issue.
>
> Fixes: 7c1c69bca43c ("ast2400: add SMC controllers (FMC and SPI)")
> Signed-off-by: Cédric Le Goater <address@hidden>
Champion!
Reviewed-by: Andrew Jeffery <address@hidden>