qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 00/14] Fixes for DP8393X SONIC device emulation


From: Jason Wang
Subject: Re: [PATCH v4 00/14] Fixes for DP8393X SONIC device emulation
Date: Thu, 20 Feb 2020 14:55:34 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0


On 2020/2/19 下午3:55, Laurent Vivier wrote:
Le 19/02/2020 à 02:57, Aleksandar Markovic a écrit :
2:54 AM Sre, 19.02.2020. Aleksandar Markovic
<address@hidden <mailto:address@hidden>> је
написао/ла:
2:06 AM Sre, 19.02.2020. Finn Thain <address@hidden
<mailto:address@hidden>> је написао/ла:
On Tue, 18 Feb 2020, Aleksandar Markovic wrote:

On Wednesday, January 29, 2020, Finn Thain
<address@hidden <mailto:address@hidden>>
wrote:

Hi All,

There are bugs in the emulated dp8393x device that can stop packet
reception in a Linux/m68k guest (q800 machine).

With a Linux/m68k v5.5 guest (q800), it's possible to remotely
trigger
an Oops by sending ping floods.

With a Linux/mips guest (magnum machine), the driver fails to probe
the dp8393x device.

With a NetBSD/arc 5.1 guest (magnum), the bugs in the device can be
fatal to the guest kernel.

Whilst debugging the device, I found that the receiver algorithm
differs from the one described in the National Semiconductor
datasheet.

This patch series resolves these bugs.

AFAIK, all bugs in the Linux sonic driver were fixed in Linux v5.5.
---

Herve,

Do your Jazz tests pass with these changes?

AFAIK those tests did not expose the NetBSD panic that is caused by
mainline QEMU (mentioned above).

I have actually run the tests you requested (Hervé described them in an
earlier thread). There was no regression. Quite the reverse -- it's no
longer possible to remotely crash the NetBSD kernel.

Apparently my testing was also the first time that the jazzsonic driver
(from the Linux/mips Magnum port) was tested successfully with QEMU. It
doesn't work in mainline QEMU.

Well, I appologize if I missed all these facts. I just did not notice
them, at least not in this form. And, yes, some "Tested-by:" by Herve
would be desirable and nice.
Or, perhaps, even "Reviewed-by:".

It would be nice to have this merged before next release because q800
machine networking is not reliable without them.


I will send the pull request that contains this series before the end of this week.

Thanks



And thank you to Finn for all his hard work on this device emulation.

Laurent








reply via email to

[Prev in Thread] Current Thread [Next in Thread]