[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Avoid cpu_physical_memory_rw() with a constant is_write argu
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH] Avoid cpu_physical_memory_rw() with a constant is_write argument |
|
Date: |
Thu, 20 Feb 2020 12:32:02 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 18/02/20 19:49, Peter Maydell wrote:
> Depending on which way we go we would either want to remove these
> casts, or not.
>
> I guess that we have more cases of 'void*', and that would
> certainly be the easier way to convert (otherwise we probably
> need to add a bunch of new casts to uint8_t* in various callsites),
> but I don't have a strong opinion. Paolo ?
I agree we should use void* (possibly const).
Paolo