[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] riscv: sifive_u: Update BIOS_FILENAME for 32-bit
|
From: |
Alistair Francis |
|
Subject: |
Re: [PATCH 2/2] riscv: sifive_u: Update BIOS_FILENAME for 32-bit |
|
Date: |
Fri, 21 Feb 2020 19:55:59 -0800 |
On Fri, Feb 21, 2020 at 6:53 PM Bin Meng <address@hidden> wrote:
>
> On Sat, Feb 22, 2020 at 3:51 AM Alistair Francis <address@hidden> wrote:
> >
> > On Thu, Feb 20, 2020 at 6:43 AM Bin Meng <address@hidden> wrote:
> > >
> > > Update BIOS_FILENAME to consider 32-bit bios image file name.
> > >
> > > Tested booting Linux v5.5 32-bit image (built from rv32_defconfig
> > > plus CONFIG_SOC_SIFIVE) with the default 32-bit bios image.
> >
> > Do we really want to support a 32-bit sifive_u machine?
> >
>
> QEMU is an emulator, why not? With 32-bit sifive_u machine, we can
> have 32-bit test coverage for SiFive specific drivers that cannot be
> done with the 'virt' machine.
That is a good point.
Reviewed-by: Alistair Francis <address@hidden>
Alistair
>
> Regards,
> Bin