[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v31 23/23] fix warning.
From: |
Peter Maydell |
Subject: |
Re: [PATCH v31 23/23] fix warning. |
Date: |
Mon, 24 Feb 2020 14:28:24 +0000 |
On Sun, 23 Feb 2020 at 13:33, Yoshinori Sato <address@hidden> wrote:
>
> Signed-off-by: Yoshinori Sato <address@hidden>
> ---
> hw/rx/rx-virt.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/rx/rx-virt.c b/hw/rx/rx-virt.c
> index 6cf7936201..4ee6647728 100644
> --- a/hw/rx/rx-virt.c
> +++ b/hw/rx/rx-virt.c
> @@ -90,8 +90,10 @@ static void rxvirt_init(MachineState *machine)
>
> /* Load kernel and dtb */
> if (kernel_filename) {
> - /* The kernel image is loaded into
> - the latter half of the SDRAM space. */
> + /*
> + The kernel image is loaded into
> + the latter half of the SDRAM space.
> + */
The comment format we prefer is described in CODING_STYLE.rst;
for block comments, and it looks like this:
/*
* Leading and closing slash-star and star-slash
* on their own line; each other line has a star
* in the left column.
*/
thanks
-- PMM
- [PATCH RESEND v31 12/22] target/rx: Collect all bytes during disassembly, (continued)
- [PATCH RESEND v31 12/22] target/rx: Collect all bytes during disassembly, Yoshinori Sato, 2020/02/23
- [PATCH RESEND v31 19/22] hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core, Yoshinori Sato, 2020/02/23
- [PATCH RESEND v31 11/22] target/rx: Emit all disassembly in one prt(), Yoshinori Sato, 2020/02/23
- [PATCH RESEND v31 09/22] target/rx: Replace operand with prt_ldmi in disassembler, Yoshinori Sato, 2020/02/23
- [PATCH RESEND v31 18/22] hw/rx: Honor -accel qtest, Yoshinori Sato, 2020/02/23
- [PATCH RESEND v31 17/22] hw/rx: RX Target hardware definition, Yoshinori Sato, 2020/02/23
- [PATCH v31 23/23] fix warning., Yoshinori Sato, 2020/02/23
- Re: [PATCH v31 23/23] fix warning.,
Peter Maydell <=
- [PATCH RESEND v31 22/22] qemu-doc.texi: Add RX section., Yoshinori Sato, 2020/02/23
- [PATCH RESEND v31 07/22] target/rx: RX disassembler, Yoshinori Sato, 2020/02/23
- [PATCH RESEND v31 16/22] hw/char: RX62N serial communication interface (SCI), Yoshinori Sato, 2020/02/23
- [PATCH RESEND v31 06/22] target/rx: CPU definition, Yoshinori Sato, 2020/02/23
- [PATCH RESEND v31 21/22] BootLinuxConsoleTest: Test the RX-Virt machine, Yoshinori Sato, 2020/02/23
- [PATCH RESEND v31 20/22] Add rx-softmmu, Yoshinori Sato, 2020/02/23
- [PATCH RESEND v31 14/22] hw/intc: RX62N interrupt controller (ICUa), Yoshinori Sato, 2020/02/23
- [PATCH RESEND v31 05/22] target/rx: TCG helper, Yoshinori Sato, 2020/02/23
- [PATCH RESEND v31 15/22] hw/timer: RX62N internal timer modules, Yoshinori Sato, 2020/02/23