Re: [PATCH v32 00/22] Add RX archtecture support

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v32 00/22] Add RX archtecture support
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
0ae38e6 qemu-doc.texi: Add RX section.
8b9073f BootLinuxConsoleTest: Test the RX-Virt machine
f8d0650 Add rx-softmmu
cf1381e hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
5d5c1a5 hw/rx: Honor -accel qtest
728f2eb hw/rx: RX Target hardware definition
8481bf0 hw/char: RX62N serial communication interface (SCI)
ee762ab hw/timer: RX62N internal timer modules
03d1012 hw/intc: RX62N interrupt controller (ICUa)
2e07be8 target/rx: Dump bytes for each insn during disassembly
2d4a25a target/rx: Collect all bytes during disassembly
2dba217 target/rx: Emit all disassembly in one prt()
98b7b5b target/rx: Use prt_ldmi for XCHG_mr disassembly
b790530 target/rx: Replace operand with prt_ldmi in disassembler
f89f8e8 target/rx: Disassemble rx_index_addr into a string
14e70b3 target/rx: RX disassembler
1ab8ca5 target/rx: CPU definition
07ea8aa target/rx: TCG helper
1870105 target/rx: TCG translation
2289e63 hw/registerfields.h: Add 8bit and 16bit register macros
d2e0f20 qemu/bitops.h: Add extract8 and extract16
149843e MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/22 Checking commit 149843e67d9b (MAINTAINERS: Add RX)
2/22 Checking commit d2e0f20da263 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 2289e638d473 (hw/registerfields.h: Add 8bit and 16bit 
register macros)
Use of uninitialized value in concatenation (.) or string at 
./scripts/checkpatch.pl line 2495.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/22 Checking commit 1870105f2530 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 07ea8aad4e81 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 5/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit 1ab8ca5e5939 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 659 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 14e70b35628e (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit f89f8e880852 (target/rx: Disassemble rx_index_addr into a 
string)
9/22 Checking commit b790530f3a0a (target/rx: Replace operand with prt_ldmi in 
disassembler)
10/22 Checking commit 98b7b5b0142e (target/rx: Use prt_ldmi for XCHG_mr 
disassembly)
11/22 Checking commit 2dba2171e47d (target/rx: Emit all disassembly in one 
prt())
12/22 Checking commit 2d4a25af9dda (target/rx: Collect all bytes during 
disassembly)
13/22 Checking commit 2e07be8ada02 (target/rx: Dump bytes for each insn during 
disassembly)
14/22 Checking commit 03d1012bb8ef (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 445 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit ee762abd1996 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 845 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 8481bf0d7b4e (hw/char: RX62N serial communication 
interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 400 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 728f2eb4ffa4 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23: 
new file mode 100644

total: 0 errors, 1 warnings, 495 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/22 Checking commit 5d5c1a55093c (hw/rx: Honor -accel qtest)
19/22 Checking commit cf1381e74ca5 (hw/rx: Restrict the RX62N microcontroller 
to the RX62N CPU core)
20/22 Checking commit f8d0650630be (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
new file mode 100644

total: 0 errors, 1 warnings, 76 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit 8b9073f76d50 (BootLinuxConsoleTest: Test the RX-Virt 
machine)
22/22 Checking commit 0ae38e67b041 (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden