|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH 3/4] virtio-pmem: do delete rq_vq in virtio_pmem_unrealize |
Date: | Tue, 25 Feb 2020 10:21:23 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 2/25/20 8:55 AM, Pan Nengyuan wrote:
Similar to other virtio-deivces, rq_vq forgot to delete in virtio_pmem_unrealize, this patch fix it.
"devices"
This device has aleardy maintained a vq pointer, thus we use the new virtio_delete_queue function directly to do the cleanup.
"already"
Reported-by: Euler Robot <address@hidden> Signed-off-by: Pan Nengyuan <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
--- hw/virtio/virtio-pmem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/virtio-pmem.c b/hw/virtio/virtio-pmem.c index 97287e923b..43399522f5 100644 --- a/hw/virtio/virtio-pmem.c +++ b/hw/virtio/virtio-pmem.c @@ -130,6 +130,7 @@ static void virtio_pmem_unrealize(DeviceState *dev, Error **errp) VirtIOPMEM *pmem = VIRTIO_PMEM(dev);host_memory_backend_set_mapped(pmem->memdev, false);+ virtio_delete_queue(pmem->rq_vq); virtio_cleanup(vdev); }
[Prev in Thread] | Current Thread | [Next in Thread] |