[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Memory: Only call ramblock_ptr when needed in qemu_ram_write
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH] Memory: Only call ramblock_ptr when needed in qemu_ram_writeback |
|
Date: |
Tue, 25 Feb 2020 17:51:51 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 25/02/20 17:02, Anthony PERARD wrote:
> On Thu, Dec 19, 2019 at 07:10:24PM +0100, Juan Quintela wrote:
>> Anthony PERARD <address@hidden> wrote:
>>> It is possible that a ramblock doesn't have memory that QEMU can
>>> access, this is the case with the Xen hypervisor.
>>>
>>> In order to avoid to trigger an assert, only call ramblock_ptr() when
>>> needed in qemu_ram_writeback(). This should fix migration of Xen
>>> guests that was broken with bd108a44bc29 ("migration: ram: Switch to
>>> ram block writeback").
>>>
>>> Signed-off-by: Anthony PERARD <address@hidden>
>>
>> Reviewed-by: Juan Quintela <address@hidden>
>>
>> This is exec.c, nothing related to migration.
>>
>> Paolo, are you taking this one?
>> It could even go through the trivial one.
>
> Hi,
>
> I'm going to send a pull request for the xen queue with this patch.
> Unless that's an issue?
No, absolutely.
Acked-by: Paolo Bonzini <address@hidden>
Paolo