[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] fuzz: fix typos in linker-script comments
From: |
Alexander Bulekov |
Subject: |
Re: [PATCH 1/2] fuzz: fix typos in linker-script comments |
Date: |
Wed, 26 Feb 2020 22:09:39 -0500 |
User-agent: |
NeoMutt/20180716 |
On 200226 2055, Eric Blake wrote:
> On 2/26/20 8:48 PM, Alexander Bulekov wrote:
> > Signed-off-by: Alexander Bulekov <address@hidden>
> > ---
> > tests/qtest/fuzz/fork_fuzz.ld | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/qtest/fuzz/fork_fuzz.ld b/tests/qtest/fuzz/fork_fuzz.ld
> > index b23a59f194..b5aad06f20 100644
> > --- a/tests/qtest/fuzz/fork_fuzz.ld
> > +++ b/tests/qtest/fuzz/fork_fuzz.ld
> > @@ -1,5 +1,5 @@
> > /* We adjust linker script modification to place all of the stuff that
> > needs to
> > - * persist across fuzzing runs into a contiguous seciton of memory. Then,
> > it is
> > + * persist across fuzzing runs into a contiguous section of memory. Then,
> > it is
> > * easy to re-map the counter-related memory as shared.
> > */
> > @@ -32,6 +32,6 @@ SECTIONS
> > __FUZZ_COUNTERS_END = .;
> > }
> > }
> > -/* Dont overwrite the SECTIONS in the default linker script. Instead
> > insert the
> > +/* Don't overwrite the SECTIONS in the default linker script. Instead
> > insert the
> > * above into the default script */
>
> As long as you're touching these two comments, checkpatch is going to
> complain that they don't follow the usual style of:
>
> /*
> * Text starts here...
> * through here.
> */
>
> If you fix that as well for these two comments,
> Reviewed-by: Eric Blake <address@hidden>
Must have missed it since the file has a .ld extension.
Thanks!
-Alex
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3226
> Virtualization: qemu.org | libvirt.org
>