qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 1/8] qcow2: introduce compression type feature


From: Eric Blake
Subject: Re: [PATCH v1 1/8] qcow2: introduce compression type feature
Date: Thu, 27 Feb 2020 07:24:49 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 2/27/20 2:21 AM, Vladimir Sementsov-Ogievskiy wrote:
27.02.2020 10:29, Denis Plotnikov wrote:
The patch adds some preparation parts for incompatible compression type
feature to Qcow2 that indicates which allow to use different compression
methods for image clusters (de)compressing.

It is implied that the compression type is set on the image creation and
can be changed only later by image conversion, thus compression type
defines the only compression algorithm used for the image, and thus,
for all image clusters.

The goal of the feature is to add support of other compression methods
to qcow2. For example, ZSTD which is more effective on compression than ZLIB.

The default compression is ZLIB. Images created with ZLIB compression type
are backward compatible with older qemu versions.

Signed-off-by: Denis Plotnikov <address@hidden>
---
  block/qcow2.c             | 105 ++++++++++++++++++++++++++++++++++++++
  block/qcow2.h             |  31 ++++++++---
  include/block/block_int.h |   1 +
  qapi/block-core.json      |  22 +++++++-
  4 files changed, 150 insertions(+), 9 deletions(-)

diff --git a/block/qcow2.c b/block/qcow2.c
index 3c754f616b..2ccb2cabd1 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c

Please, add to .git/config:

[diff]
     orderFile = /path/to/qemu/scripts/git.orderfile

This will force git format-patch to sort files in more comfortable order (header changes first, etc).

As I learned yesterday, git 2.23 and 2.24 have a bug where git format-patch fails to honor diff.orderfile (fixed in 2.25): https://bugzilla.redhat.com/show_bug.cgi?id=1807681 (and that explains why some of my recent patches have not been ordered the way I wanted, as Fedora 31 currently has a git from the broken window in time)


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]