Re: [PATCH v2] softmmu/vl.c: fix too slow TCG regression

[Peter Maydell]

On Thu, 27 Feb 2020 at 16:15, Igor Mammedov <address@hidden> wrote:
>
> Commit a1b18df9a4 moved -m option parsing after configure_accelerators()
> that broke TCG accelerator initialization which accesses global ram_size
> from size_code_gen_buffer() which is equal to 0 at that moment.
>
> Partially revert a1b18df9a4, by returning set_memory_options() to its
> original location and only keep 32-bit host VA check and 'memory-backend'
> size check introduced by fe64d06afc at current place.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> v2:
>   * check if user used -m SZ before comparing ram_size with backend's size.
>     Fixes case where qemu exits with error when backend's size doesn't match
>     dafault ram_size (i.e. user haven't used -m option  at all)
>     (Peter Maydell <address@hidden>)
>   * keep order addr space size check for 32-bit host after
>     backend size check. So it would be affected by backend's size as well.

Applied to master as a fix for the tcg perf regression, thanks.

-- PMM