[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/6] util: Replace fprintf(stderr, "*\n" with error_report
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v2 2/6] util: Replace fprintf(stderr, "*\n" with error_report() |
|
Date: |
Fri, 28 Feb 2020 18:41:17 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Philippe Mathieu-Daudé <address@hidden> writes:
> On 2/28/20 10:50 AM, Philippe Mathieu-Daudé wrote:
[...]
>> Thanks for your review. I'll drop the changes in util/oslib-win32.c
>> for for now, and add a note in my TODO for after the 5.0 release.
>
> Well if I follow this line, I'v to drop the changes in util/osdep.c too.
> Maybe we can keep fprintf() for now and improve the error message, and
> do the fprintf -> error_report cleanup later?
I recommend to convert from fprintf() to error_report() & friends and
improve the message all in one go.
Separating different kinds of changes makes sense when some kinds are
mechanical and the resulting mechanical patches are large. These
patches aren't large.
But it's really up to you. I'm not going to veto an improvement only
because further improvement is called for.
[PATCH v2 3/6] util/oslib-win32: Improve error report by calling error_setg_win32(), Philippe Mathieu-Daudé, 2020/02/27
[PATCH v2 5/6] qga: Fix a memory leak, Philippe Mathieu-Daudé, 2020/02/27
[PATCH v2 4/6] util/osdep: Improve error report by calling error_setg_win32(), Philippe Mathieu-Daudé, 2020/02/27
[PATCH v2 6/6] qga: Improve error report by calling error_setg_win32(), Philippe Mathieu-Daudé, 2020/02/27