[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 6/8] accel/tcg: remove link between guest ram and TCG cache size
From: |
Richard Henderson |
Subject: |
[PULL 6/8] accel/tcg: remove link between guest ram and TCG cache size |
Date: |
Fri, 28 Feb 2020 18:43:45 -0800 |
From: Alex Bennée <address@hidden>
Basing the TB cache size on the ram_size was always a little heuristic
and was broken by a1b18df9a4 which caused ram_size not to be fully
realised at the time we initialise the TCG translation cache.
The current DEFAULT_CODE_GEN_BUFFER_SIZE may still be a little small
but follow-up patches will address that.
Fixes: a1b18df9a4
Cc: Igor Mammedov <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Niek Linnenbank <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
accel/tcg/translate-all.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index 238b0e575b..5b66af783b 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -938,15 +938,7 @@ static inline size_t size_code_gen_buffer(size_t tb_size)
{
/* Size the buffer. */
if (tb_size == 0) {
-#ifdef USE_STATIC_CODE_GEN_BUFFER
tb_size = DEFAULT_CODE_GEN_BUFFER_SIZE;
-#else
- /* ??? Needs adjustments. */
- /* ??? If we relax the requirement that CONFIG_USER_ONLY use the
- static buffer, we could size this on RESERVED_VA, on the text
- segment size of the executable, or continue to use the default. */
- tb_size = (unsigned long)(ram_size / 4);
-#endif
}
if (tb_size < MIN_CODE_GEN_BUFFER_SIZE) {
tb_size = MIN_CODE_GEN_BUFFER_SIZE;
--
2.20.1
- [PULL 0/8] tcg patch queue, Richard Henderson, 2020/02/28
- [PULL 1/8] accel/tcg: fix race in cpu_exec_step_atomic (bug 1863025), Richard Henderson, 2020/02/28
- [PULL 6/8] accel/tcg: remove link between guest ram and TCG cache size,
Richard Henderson <=
- [PULL 7/8] accel/tcg: only USE_STATIC_CODE_GEN_BUFFER on 32 bit hosts, Richard Henderson, 2020/02/28
- [PULL 8/8] accel/tcg: increase default code gen buffer size for 64 bit, Richard Henderson, 2020/02/28
- [PULL 3/8] tcg/arm: Split out tcg_out_epilogue, Richard Henderson, 2020/02/28
- [PULL 5/8] accel/tcg: use units.h for defining code gen buffer sizes, Richard Henderson, 2020/02/28
- [PULL 2/8] compiler.h: Don't use compile-time assert when __NO_INLINE__ is defined, Richard Henderson, 2020/02/28
- [PULL 4/8] tcg/arm: Expand epilogue inline, Richard Henderson, 2020/02/28