[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [EXTERNAL] Re: PATCH] WHPX: TSC get and set should be dependent on V
From: |
Paolo Bonzini |
Subject: |
Re: [EXTERNAL] Re: PATCH] WHPX: TSC get and set should be dependent on VM state |
Date: |
Sat, 29 Feb 2020 10:39:36 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 28/02/20 22:02, Sunil Muthuswamy wrote:
>> -----Original Message-----
>> From: Paolo Bonzini <address@hidden>
>> Sent: Friday, February 28, 2020 2:45 AM
>> To: Sunil Muthuswamy <address@hidden>; Richard Henderson <address@hidden>;
>> Eduardo Habkost
>> <address@hidden>
>> Cc: address@hidden; Stefan Weil <address@hidden>
>> Subject: [EXTERNAL] Re: PATCH] WHPX: TSC get and set should be dependent on
>> VM state
>>
>> On 26/02/20 21:54, Sunil Muthuswamy wrote:
>>> Currently, TSC is set as part of the VM runtime state. Setting TSC at
>>> runtime is heavy and additionally can have side effects on the guest,
>>> which are not very resilient to variances in the TSC. This patch uses
>>> the VM state to determine whether to set TSC or not. Some minor
>>> enhancements for getting TSC values as well that considers the VM state.
>>>
>>> Additionally, while setting the TSC, the partition is suspended to
>>> reduce the variance in the TSC value across vCPUs.
>>>
>>> Signed-off-by: Sunil Muthuswamy <address@hidden>
>>
>> Looks good. Do you want me to queue this until you can have your GPG
>> key signed? (And also, I can help you sign it of course).
>>
>
> Yes, please. Thanks.
>
> I haven't used GPG keys before. What would I be using it for?
You'd be using it to include a signed tags in a pull requests; that is,
the git tag that you ask to pull has a cryptographic signature attached
to it.
Paolo