Re: [RFC 4/5] qmp: add QMP command virtio-queue-element

[Eric Blake]

On 4/2/20 5:03 AM, Laurent Vivier wrote:
> This new command shows the information of a VirtQueue element.
>
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
>   hw/virtio/virtio-stub.c |  7 ++++
>   hw/virtio/virtio.c      | 85 +++++++++++++++++++++++++++++++++++++++++
>   qapi/virtio.json        | 85 +++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 177 insertions(+)

> +##
> +# @VirtioRingDesc:
> +#
> +# @addr: guest physical address of the descriptor data
> +#
> +# @len: length of the descriptor data
> +#
> +# @flags: descriptor flags (write-only, read-only, ...)
> +#
> +# Since: 5.1
> +#
> +##
> +
> +{ 'struct': 'VirtioRingDesc',
> +  'data': {
> +    'addr': 'uint64',
> +    'len': 'uint32',
> +    'flags': 'uint16'

Again, flags should probably be an array of enum values, rather than a 
bare int.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org