[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/core: properly terminate loading .hex on EOF record
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH] hw/core: properly terminate loading .hex on EOF record |
|
Date: |
Thu, 2 Apr 2020 09:50:43 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 4/1/20 12:38 PM, Alex Bennée wrote:
> The https://makecode.microbit.org/#editor generates slightly weird
> .hex files which work fine on a real microbit but causes QEMU to
> choke. The reason is extraneous data after the EOF record which causes
> the loader to attempt to write a bigger file than it should to the
> "rom". According to the HEX file spec an EOF really should be the last
> thing we process so lets do that.
>
> Reported-by: Ursula Bennée <address@hidden>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
> hw/core/loader.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson <address@hidden>
r~