Re: [PATCH v5 for-5.0] configure: warn if not using a separate build directory

[Daniel P . Berrangé]

On Mon, Apr 06, 2020 at 10:38:45AM -0500, Eric Blake wrote:
> On 4/6/20 10:33 AM, Daniel P. Berrangé wrote:
> > Running configure directly from the source directory is a build
> > configuration that will go away in future. It is also not currently
> > covered by any automated testing. Display a deprecation warning if
> 
> Calling it a deprecation warning may be overkill now that we've toned down
> the language.
> 
> > the user attempts to use an in-srcdir build setup, so that they are
> > aware that they're building QEMU in an undesirable manner.
> > 
> > Reviewed-by: Aleksandar Markovic <address@hidden>
> > Tested-by: Philippe Mathieu-Daudé <address@hidden>
> > Signed-off-by: Daniel P. Berrangé <address@hidden>
> > ---
> > 
> 
> > +if test "$in_srcdir" = "yes"; then
> > +    echo
> > +    echo "NOTE: we recommend against building in the source directory"
> > +    echo
> > +    echo "You've run the 'configure' script directly from the source"
> > +    echo "directory. This will work, but we recommend using a separate"
> > +    echo "build directory, especially if you plan to work with the QEMU"
> > +    echo "sources rather than just building it once. You can switch to"
> > +    echo "a separate build directory like this:"
> > +    echo
> > +    echo "  $ mkdir build"
> 
> As I pointed out on v4, this is missing a step.  Since this is just a
> warning and not fatal, './configure' completed and polluted the in-tree
> directories to the point that following these instructions will fail unless
> they start with 'make distclean' prior to the other steps.

Hmm, I was thinking this wasn't needed because we would assume this  was
a fresh checkout, but I had forgot that this very run of configure will
have polluted it.

> 
> > +    echo "  $ cd build"
> > +    echo "  $ ../configure"
> > +    echo "  $ make"
> > +    echo
> > +fi
> > +
> >   config_host_mak="config-host.mak"
> >   echo "# Automatically generated by configure - do not modify" 
> > >config-all-disas.mak
> > 
> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3226
> Virtualization:  qemu.org | libvirt.org
> 
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|