Re: [PATCH v5 0/8] pci_expander_brdige:acpi:Support pxb-pcie for ARM

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v5 0/8] pci_expander_brdige:acpi:Support pxb-pcie for ARM
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
27a7b3d unit-test: add the binary file and clear diff.h
098d947 unit-test: Add testcase for pxb
43ed769 unit-test: The files changed.
3cfb18f acpi: align the size to 128k
0c920d9 acpi: Refactor the source of host bridge and build tables for pxb
1043623 acpi:Extract crs build form acpi_build.c
776ec24 fw_cfg: Write the extra roots into the fw_cfg
f660b50 acpi:Extract two APIs from acpi_dsdt_add_pci

=== OUTPUT BEGIN ===
1/8 Checking commit f660b50acf36 (acpi:Extract two APIs from acpi_dsdt_add_pci)
2/8 Checking commit 776ec24ca7b9 (fw_cfg: Write the extra roots into the fw_cfg)
3/8 Checking commit 104362358b93 (acpi:Extract crs build form acpi_build.c)
4/8 Checking commit 0c920d9293fe (acpi: Refactor the source of host bridge and 
build tables for pxb)
5/8 Checking commit 3cfb18f7bc91 (acpi: align the size to 128k)
6/8 Checking commit 43ed7693d63f (unit-test: The files changed.)
ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both 
tests/qtest/bios-tables-test-allowed-diff.h and hw/arm/virt-acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both 
tests/qtest/bios-tables-test-allowed-diff.h and hw/arm/virt-acpi-build.c found

total: 2 errors, 0 warnings, 2 lines checked

Patch 6/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/8 Checking commit 098d947a00b8 (unit-test: Add testcase for pxb)
ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both 
tests/qtest/bios-tables-test-allowed-diff.h and tests/qtest/bios-tables-test.c 
found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both 
tests/qtest/bios-tables-test-allowed-diff.h and tests/qtest/bios-tables-test.c 
found

total: 2 errors, 0 warnings, 76 lines checked

Patch 7/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

8/8 Checking commit 27a7b3d1bc62 (unit-test: add the binary file and clear 
diff.h)
ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/virt/DSDT.pxb and 
tests/qtest/bios-tables-test.c found

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both 
tests/qtest/bios-tables-test-allowed-diff.h and tests/qtest/bios-tables-test.c 
found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both 
tests/qtest/bios-tables-test-allowed-diff.h and tests/qtest/bios-tables-test.c 
found

total: 3 errors, 1 warnings, 1 lines checked

Patch 8/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden