[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 09/11] xen/pt: Fix flawed conversion to realize()
|
From: |
Paul Durrant |
|
Subject: |
RE: [PATCH 09/11] xen/pt: Fix flawed conversion to realize() |
|
Date: |
Mon, 20 Apr 2020 09:58:35 +0100 |
> -----Original Message-----
> From: Markus Armbruster <address@hidden>
> Sent: 20 April 2020 09:33
> To: address@hidden
> Cc: Stefano Stabellini <address@hidden>; Anthony Perard <address@hidden>; Paul
> Durrant <address@hidden>; address@hidden
> Subject: [PATCH 09/11] xen/pt: Fix flawed conversion to realize()
>
> The conversion of xen_pt_initfn() to xen_pt_realize() blindly replaced
> XEN_PT_ERR() by error_setg(). Several error conditions that did not
> fail xen_pt_initfn() now fail xen_pt_realize(). Unsurprisingly, the
> cleanup on these errors looks highly suspicious.
>
> Revert the inappropriate replacements.
>
> Fixes: 5a11d0f7549e24a10e178a9dc8ff5e698031d9a6
> Cc: Stefano Stabellini <address@hidden>
> Cc: Anthony Perard <address@hidden>
> Cc: Paul Durrant <address@hidden>
> Cc: address@hidden
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Paul Durrant <address@hidden>
- Re: [PATCH 10/11] io: Fix qio_channel_socket_close() error handling, (continued)
- [PATCH 01/11] cryptodev: Fix cryptodev_builtin_cleanup() error API violation, Markus Armbruster, 2020/04/20
- [PATCH 02/11] block/file-posix: Fix check_cache_dropped() error handling, Markus Armbruster, 2020/04/20
- [PATCH 04/11] cpus: Proper range-checking for -icount shift=N, Markus Armbruster, 2020/04/20
- [PATCH 07/11] bochs-display: Fix vgamem=SIZE error handling, Markus Armbruster, 2020/04/20
- [PATCH 08/11] virtio-net: Fix duplex=... and speed=... error handling, Markus Armbruster, 2020/04/20
- [PATCH 09/11] xen/pt: Fix flawed conversion to realize(), Markus Armbruster, 2020/04/20
- RE: [PATCH 09/11] xen/pt: Fix flawed conversion to realize(),
Paul Durrant <=
- Re: [PATCH 00/11] Miscellaneous error handling fixes, no-reply, 2020/04/20