Re: [PATCH v7 09/10] iotests: Test committing to short backing file

[Vladimir Sementsov-Ogievskiy]

24.04.2020 15:54, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>


Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>

> ---

[..]

> +
> +        # After this, 0 to base_size should be allocated/zeroed.

Actually, top_size_old to base_size, yes? (sorry, nitpicking, missed on 
previous review).

> +        #
> +        # In theory, leaving base_size to top_size_new unallocated would be
> +        # correct, but in practice, if we zero out anything, we zero out
> +        # everything up to top_size_new.
> +        iotests.qemu_img_log('resize', '-f', iotests.imgfmt,
> +                             '--preallocation', prealloc, top, top_size_new)
> +        iotests.qemu_io_log('-c', 'read -P 0 %s 64k' % off, top)
> +        iotests.qemu_io_log('-c', 'map', top)
> +        iotests.qemu_img_log('map', '--output=json', top)



--
Best regards,
Vladimir