[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/6] vmdk: Fix zero cluster allocation
|
From: |
Kevin Wolf |
|
Subject: |
Re: [PATCH 2/6] vmdk: Fix zero cluster allocation |
|
Date: |
Thu, 30 Apr 2020 16:32:46 +0200 |
Am 30.04.2020 um 16:19 hat Eric Blake geschrieben:
> On 4/30/20 8:30 AM, Kevin Wolf wrote:
> > m_data must be contain valid data even for zero clusters when no cluster
> > was allocated in the image file. Without this, zero writes segfault with
> > images that have zeroed_grain=on.
>
> zero_grained=on ?
No, zeroed_grain is the actual name of the option.
I don't really know what a grain is in VMDK terminology, but about the
only thing that felt healthy about the code I touched was that it has
whole-grain buffers. :-)
Kevin
- [PATCH 0/6] vmdk: Fix zero cluster handling, Kevin Wolf, 2020/04/30
- [PATCH 2/6] vmdk: Fix zero cluster allocation, Kevin Wolf, 2020/04/30
- [PATCH 1/6] vmdk: Rename VmdkMetaData.valid to new_allocation, Kevin Wolf, 2020/04/30
- [PATCH 3/6] vmdk: Fix partial overwrite of zero cluster, Kevin Wolf, 2020/04/30
- [PATCH 4/6] vmdk: Don't update L2 table for zero write on zero cluster, Kevin Wolf, 2020/04/30
- [PATCH 5/6] vmdk: Flush only once in vmdk_L2update(), Kevin Wolf, 2020/04/30
- [PATCH 6/6] iotests: vmdk: Enable zeroed_grained=on by default, Kevin Wolf, 2020/04/30