[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 4/9] tests/tcg: drop inferior.was_attached() test
|
From: |
Alex Bennée |
|
Subject: |
[PATCH v1 4/9] tests/tcg: drop inferior.was_attached() test |
|
Date: |
Thu, 30 Apr 2020 20:01:17 +0100 |
This test seems flaky and reports attachment even when we failed to
negotiate the architecture. However the fetching of the guest
architecture will fail tripping up the gdb AttributeError which will
trigger our early no error status exit from the test
Signed-off-by: Alex Bennée <address@hidden>
---
tests/tcg/aarch64/gdbstub/test-sve-ioctl.py | 3 ---
tests/tcg/aarch64/gdbstub/test-sve.py | 3 ---
2 files changed, 6 deletions(-)
diff --git a/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
b/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
index 387b2fc20a..972cf73c31 100644
--- a/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
+++ b/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
@@ -58,9 +58,6 @@ def run_test():
#
try:
inferior = gdb.selected_inferior()
- if inferior.was_attached == False:
- print("SKIPPING (failed to attach)", file=sys.stderr)
- exit(0)
arch = inferior.architecture()
report(arch.name() == "aarch64", "connected to aarch64")
except (gdb.error, AttributeError):
diff --git a/tests/tcg/aarch64/gdbstub/test-sve.py
b/tests/tcg/aarch64/gdbstub/test-sve.py
index 5995689625..b96bdbb99a 100644
--- a/tests/tcg/aarch64/gdbstub/test-sve.py
+++ b/tests/tcg/aarch64/gdbstub/test-sve.py
@@ -59,9 +59,6 @@ def run_test():
#
try:
inferior = gdb.selected_inferior()
- if inferior.was_attached == False:
- print("SKIPPING (failed to attach)", file=sys.stderr)
- exit(0)
arch = inferior.architecture()
report(arch.name() == "aarch64", "connected to aarch64")
except (gdb.error, AttributeError):
--
2.20.1
- [PATCH v1 0/9] gdbstub/next, Alex Bennée, 2020/04/30
- [PATCH v1 1/9] configure: favour gdb-multiarch if we have it, Alex Bennée, 2020/04/30
- [PATCH v1 2/9] gdbstub: Introduce gdb_get_float64() to get 64-bit float registers, Alex Bennée, 2020/04/30
- [PATCH v1 4/9] tests/tcg: drop inferior.was_attached() test,
Alex Bennée <=
- [PATCH v1 3/9] tests/tcg: better trap gdb failures, Alex Bennée, 2020/04/30
- [PATCH v1 5/9] gdbstub: eliminate gdbserver_fd global, Alex Bennée, 2020/04/30
- [PATCH v1 7/9] tests/guest-debug: use the unix socket for linux-user tests, Alex Bennée, 2020/04/30
- [PATCH v1 6/9] gdbstub/linux-user: support debugging over a unix socket, Alex Bennée, 2020/04/30
- [PATCH v1 9/9] target/m68k: fix gdb for m68xxx, Alex Bennée, 2020/04/30
- [PATCH v1 8/9] tests/tcg: add a multiarch linux-user gdb test, Alex Bennée, 2020/04/30