Re: [PULL 15/29] dwc-hsotg (dwc2) USB host controller register definitions

[Philippe Mathieu-Daudé]

Hi Paul,

On 6/5/20 6:49 PM, Peter Maydell wrote:
> From: Paul Zimmerman <pauldzim@gmail.com>
> 
> Import the dwc-hsotg (dwc2) register definitions file from the
> Linux kernel. This is a copy of drivers/usb/dwc2/hw.h from the
> mainline Linux kernel, the only changes being to the header, and
> two instances of 'u32' changed to 'uint32_t' to allow it to
> compile. Checkpatch throws a boatload of errors due to the tab
> indentation, but I would rather import it as-is than reformat it.
> 
> Signed-off-by: Paul Zimmerman <pauldzim@gmail.com>
> Message-id: 20200520235349.21215-3-pauldzim@gmail.com
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  include/hw/usb/dwc2-regs.h | 899 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 899 insertions(+)
>  create mode 100644 include/hw/usb/dwc2-regs.h

Can you add a section in MAINTAINERS to cover the dwc2 files you added?
Being listed as reviewer would help Gerd maintaining it, because that
way you'd get notifications if someone makes a change.

Something like:

-- >8 --
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1652,6 +1652,13 @@ M: Samuel Thibault <samuel.thibault@ens-lyon.org>
 S: Maintained
 F: hw/usb/dev-serial.c

+USB (DWC2)
+M: Gerd Hoffmann <kraxel@redhat.com>
+R: Paul Zimmerman <pauldzim@gmail.com>
+S: Maintained
+F: hw/usb/hcd-dwc2.*
+F: include/hw/usb/dwc2-regs.h
+
 VFIO
 M: Alex Williamson <alex.williamson@redhat.com>
 S: Supported
---

Thanks,

Phil.