[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] softmmu/vl: Include "qemu/rcu.h" for rcu_disable_atfork()
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] softmmu/vl: Include "qemu/rcu.h" for rcu_disable_atfork() |
|
Date: |
Thu, 9 Jul 2020 17:51:19 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 7/9/20 5:25 PM, Alexander Bulekov wrote:
> Reviewed-by: Alexander Bulekov <alxndr@bu.edu>
>
> If rcu.h should be explicitly included, should any of these other files
> that reference the rcu but do not explicitly #include qemu/rcu.h also
> get such includes?
Personally I think so, yes.
>
> util/qht.c
> 166: struct rcu_head rcu;
>
> migration/savevm.c
> 1822: rcu_register_thread();
>
> util/log.c
> 43: rcu_read_lock();
>
> linux-user/syscall.c
> 6000: rcu_register_thread();
>
> hw/virtio/virtio.c
> 74: struct rcu_head rcu;
>
> target/arm/kvm.c
> 998: rcu_read_lock();
>