[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] tests: fix "make check-qtest" for modular builds
From: |
Thomas Huth |
Subject: |
Re: [PATCH 1/2] tests: fix "make check-qtest" for modular builds |
Date: |
Mon, 13 Jul 2020 07:36:20 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 10/07/2020 22.36, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> tests/qtest/Makefile.include | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/qtest/Makefile.include b/tests/qtest/Makefile.include
> index 98af2c2d9338..6a0276fd42dd 100644
> --- a/tests/qtest/Makefile.include
> +++ b/tests/qtest/Makefile.include
> @@ -277,6 +277,7 @@ tests/qtest/tco-test$(EXESUF): tests/qtest/tco-test.o
> $(libqos-pc-obj-y)
> tests/qtest/virtio-ccw-test$(EXESUF): tests/qtest/virtio-ccw-test.o
> tests/qtest/display-vga-test$(EXESUF): tests/qtest/display-vga-test.o
> tests/qtest/qom-test$(EXESUF): tests/qtest/qom-test.o
> +tests/qtest/modules-test$(EXESUF): tests/qtest/modules-test.o
> tests/qtest/test-hmp$(EXESUF): tests/qtest/test-hmp.o
> tests/qtest/machine-none-test$(EXESUF): tests/qtest/machine-none-test.o
> tests/qtest/device-plug-test$(EXESUF): tests/qtest/device-plug-test.o
What was the error that you run into here? ... some words in the commit
message would be nice. Actually, I always wondered why we need a
separate entry for each and every test here ... I'd rather expect that
this is handled by a normal generic make rule instead?
Thomas