Re: [PATCH 02/12] target/ppc: Remove superfluous breaks

[Philippe Mathieu-Daudé]

On 7/13/20 11:03 AM, Yi Wang wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
> 
> Remove superfluous breaks, as there is a "return" before them.
> 
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> 

I hadn't reviewed this patch, but now I did (you can strip the space
at the end of the line).

> ---
>  target/ppc/misc_helper.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/target/ppc/misc_helper.c b/target/ppc/misc_helper.c
> index 55b68d1..e43a3b4 100644
> --- a/target/ppc/misc_helper.c
> +++ b/target/ppc/misc_helper.c
> @@ -234,25 +234,20 @@ target_ulong helper_clcs(CPUPPCState *env, uint32_t arg)
>      case 0x0CUL:
>          /* Instruction cache line size */
>          return env->icache_line_size;
> -        break;
>      case 0x0DUL:
>          /* Data cache line size */
>          return env->dcache_line_size;
> -        break;
>      case 0x0EUL:
>          /* Minimum cache line size */
>          return (env->icache_line_size < env->dcache_line_size) ?
>              env->icache_line_size : env->dcache_line_size;
> -        break;
>      case 0x0FUL:
>          /* Maximum cache line size */
>          return (env->icache_line_size > env->dcache_line_size) ?
>              env->icache_line_size : env->dcache_line_size;
> -        break;
>      default:
>          /* Undefined */
>          return 0;
> -        break;
>      }
>  }
>  
>