Re: [PATCH v2 0/4] target-hppa fixes

[Helge Deller]

Hi Michael,

On 01.08.20 18:47, Michael Tokarev wrote:
> 01.08.2020 16:13, Helge Deller wrote:
>> A few late fixes for target-hppa:
>>
>> * Fix the SeaBIOS-hppa firmware build with gcc-10 on Debian
>
> It looks like you forgot the above change somehow.

Actually, no, I did not forgot this patch.
It's part of the seabios-hppa repo, see here:
https://github.com/hdeller/seabios-hppa/commit/14a26ffb0d9ad1fc510da5d03215b0e36f717fce

In this qemu patch series the binary firmware-hppa.img blob I
sent was built with it.

> And me too,
> I forgot to send you a proper [PATCH] for this.  This is what
> I use in Debian:
>
> From: Michael Tokarev <mjt@tls.msk.ru>
> Subject: seabios-hppa: add -fno-ipa-sra to the compiler flags
> Date: Wed, 22 Jul 2020 22:15:46 +0300
>
> This allows seabios-hppa to build with gcc-10. Or else the
> compiler generates eg memset.isra.0 symbols instead of memset,
> and the final link step fails due to missing memset.
>
> Previous versions of gcc, for quite some time already, recognizes
> this option but it does nothing since apparently no-ipa-sra is the
> default. So there's no harm in adding it unconditionally, it seems.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
>
> index c0d5d958..1b7757e8 100644
> --- a/Makefile.parisc
> +++ b/Makefile.parisc
> @@ -76 +76 @@ COMMONCFLAGS := -I$(OUT) -Isrc -Ivgasrc -Os -MD -g \
> -    -fno-builtin-printf
> +    -fno-builtin-printf -fno-ipa-sra
>
>
> This should not be required for the actual binary once it is built,
> however.

Yep.

Thanks!
Helge