Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline)

[Daniel P . Berrangé]

On Mon, Aug 03, 2020 at 10:18:29AM +0200, Markus Armbruster wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
> 
> > - the single-quote strings, which are not particularly useful in QAPI schema
> 
> Every single string in the QAPI schema uses them, though.
> 
> I have no idea why Anthony put them in the QAPI schema language.
> 
> We could remove them from the QAPI schema language.  Flag day, and
> git-blame becomes pretty much useless for a couple of years.

I don't think the git-blame issue is a big deal, just a minor inconvenience.
Say you find the line of code you are examining hits the commit which did
the refactoring. You merely have to run git blame a second time passing
SHA-OF-REFACTOR^1 as an arg. 


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|