[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/arm/translate.c: Delete/amend incorrect comments
From: |
Richard Henderson |
Subject: |
Re: [PATCH] target/arm/translate.c: Delete/amend incorrect comments |
Date: |
Mon, 3 Aug 2020 20:54:43 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 8/3/20 6:28 AM, Peter Maydell wrote:
> In arm_tr_init_disas_context() we have a FIXME comment that suggests
> "cpu_M0 can probably be the same as cpu_V0". This isn't in fact
> possible: cpu_V0 is used as a temporary inside gen_iwmmxt_shift(),
> and that function is called in various places where cpu_M0 contains a
> live value (i.e. between gen_op_iwmmxt_movq_M0_wRn() and
> gen_op_iwmmxt_movq_wRn_M0() calls). Remove the comment.
>
> We also have a comment on the declarations of cpu_V0/V1/M0 which
> claims they're "for efficiency". This isn't true with modern TCG, so
> replace this comment with one which notes that they're only used with
> the iwmmxt decode.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~