[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-5.2 2/5] spapr/xive: Simplify kvmppc_xive_disconnect()
From: |
Greg Kurz |
Subject: |
[PATCH for-5.2 2/5] spapr/xive: Simplify kvmppc_xive_disconnect() |
Date: |
Wed, 05 Aug 2020 19:35:29 +0200 |
User-agent: |
StGit/0.21 |
Since this function begins with:
/* The KVM XIVE device is not in use */
if (!xive || xive->fd == -1) {
return;
}
we obviously don't need to check xive->fd again.
Signed-off-by: Greg Kurz <groug@kaod.org>
---
hw/intc/spapr_xive_kvm.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/intc/spapr_xive_kvm.c b/hw/intc/spapr_xive_kvm.c
index d55ea4670e0e..893a1ee77e70 100644
--- a/hw/intc/spapr_xive_kvm.c
+++ b/hw/intc/spapr_xive_kvm.c
@@ -873,10 +873,8 @@ void kvmppc_xive_disconnect(SpaprInterruptController *intc)
* and removed from the list of devices of the VM. The VCPU
* presenters are also detached from the device.
*/
- if (xive->fd != -1) {
- close(xive->fd);
- xive->fd = -1;
- }
+ close(xive->fd);
+ xive->fd = -1;
kvm_kernel_irqchip = false;
kvm_msi_via_irqfd_allowed = false;
- [PATCH for-5.2 0/5] spapr: Cleanups for XIVE and PHB, Greg Kurz, 2020/08/05
- [PATCH for-5.2 1/5] spapr/xive: Fix xive->fd if kvm_create_device() fails, Greg Kurz, 2020/08/05
- [PATCH for-5.2 2/5] spapr/xive: Simplify kvmppc_xive_disconnect(),
Greg Kurz <=
- [PATCH for-5.2 3/5] ppc/xive: Introduce dedicated kvm_irqchip_in_kernel() wrappers, Greg Kurz, 2020/08/05
- [PATCH for-5.2 4/5] spapr/xive: Convert KVM device fd checks to assert(), Greg Kurz, 2020/08/05
- [PATCH for-5.2 5/5] spapr: Simplify error handling in spapr_phb_realize(), Greg Kurz, 2020/08/05
- Re: [PATCH for-5.2 0/5] spapr: Cleanups for XIVE and PHB, no-reply, 2020/08/05