Re: [PATCH] target/arm: Delete unused ARM_FEATURE_CRC

[Philippe Mathieu-Daudé]

On 8/5/20 11:08 PM, Peter Maydell wrote:
> In commit 962fcbf2efe57231a9f5df we converted the uses of the
> ARM_FEATURE_CRC bit to use the aa32_crc32 isar_feature test
> instead. However we forgot to remove the now-unused definition
> of the feature name in the enum. Delete it now.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  target/arm/cpu.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/target/arm/cpu.h b/target/arm/cpu.h
> index 9e8ed423ea1..9d2845c1797 100644
> --- a/target/arm/cpu.h
> +++ b/target/arm/cpu.h
> @@ -1950,7 +1950,6 @@ enum arm_features {
>      ARM_FEATURE_V8,
>      ARM_FEATURE_AARCH64, /* supports 64 bit mode */
>      ARM_FEATURE_CBAR, /* has cp15 CBAR */
> -    ARM_FEATURE_CRC, /* ARMv8 CRC instructions */
>      ARM_FEATURE_CBAR_RO, /* has cp15 CBAR and it is read-only */
>      ARM_FEATURE_EL2, /* has EL2 Virtualization support */
>      ARM_FEATURE_EL3, /* has EL3 Secure monitor support */
> 

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>