[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-5.2 04/19] aspeed/scu: Fix valid access size on AST2400
From: |
Cédric Le Goater |
Subject: |
[PATCH for-5.2 04/19] aspeed/scu: Fix valid access size on AST2400 |
Date: |
Thu, 6 Aug 2020 15:20:51 +0200 |
The read access size of the SCU registers can be 1/2/4 bytes and write
is 4 bytes. Set the min access size to 1 byte to cover both read and
write operations on the AST2400 but keep the min access size of the
other SoCs to 4 bytes as this is an unusual access size.
This fixes support for some old firmware doing 2 bytes reads on the
AST2400 SoC.
Reported-by: erik-smit <erik.lucas.smit@gmail.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
hw/misc/aspeed_scu.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c
index ec4fef900e27..764222404bef 100644
--- a/hw/misc/aspeed_scu.c
+++ b/hw/misc/aspeed_scu.c
@@ -328,9 +328,10 @@ static const MemoryRegionOps aspeed_ast2400_scu_ops = {
.read = aspeed_scu_read,
.write = aspeed_ast2400_scu_write,
.endianness = DEVICE_LITTLE_ENDIAN,
- .valid.min_access_size = 4,
- .valid.max_access_size = 4,
- .valid.unaligned = false,
+ .valid = {
+ .min_access_size = 1,
+ .max_access_size = 4,
+ },
};
static const MemoryRegionOps aspeed_ast2500_scu_ops = {
--
2.25.4
- [PATCH for-5.2 00/19] aspeed: mostly cleanups and some extensions, Cédric Le Goater, 2020/08/06
- [PATCH for-5.2 01/19] m25p80: Return the JEDEC ID twice for mx25l25635e, Cédric Le Goater, 2020/08/06
- [PATCH for-5.2 02/19] m25p80: Add support for mx25l25635f, Cédric Le Goater, 2020/08/06
- [PATCH for-5.2 03/19] m25p80: Add support for n25q512ax3, Cédric Le Goater, 2020/08/06
- [PATCH for-5.2 06/19] aspeed/smc: Fix MemoryRegionOps definition, Cédric Le Goater, 2020/08/06
- [PATCH for-5.2 04/19] aspeed/scu: Fix valid access size on AST2400,
Cédric Le Goater <=
- Re: [PATCH for-5.2 04/19] aspeed/scu: Fix valid access size on AST2400, Joel Stanley, 2020/08/06
- [PATCH for-5.2 05/19] hw/arm/aspeed: Add board model for Supermicro X11 BMC, Cédric Le Goater, 2020/08/06
- [PATCH for-5.2 08/19] aspeed/sdhci: Fix reset sequence, Cédric Le Goater, 2020/08/06