[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/3] async: always set ctx->notified in aio_notify()
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH v3 2/3] async: always set ctx->notified in aio_notify() |
|
Date: |
Thu, 6 Aug 2020 15:45:33 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 |
On 06/08/20 15:18, Stefan Hajnoczi wrote:
> + atomic_set(&ctx->notified, false);
> +
> + /*
> + * Write ctx->notified before reading e.g. bh->flags. Pairs with smp_mb
> in
> + * aio_notify.
> + */
> + smp_wmb();
Sorry I was not clear: the memory barrier has to be smp_mb(), but the
comment has to say smp_wmb(). No need to repost for this.
Paolo
- [PATCH v3 0/3] aio-posix: keep aio_notify_me disabled during polling, Stefan Hajnoczi, 2020/08/06
- [PATCH v3 1/3] async: rename event_notifier_dummy_cb/poll(), Stefan Hajnoczi, 2020/08/06
- [PATCH v3 2/3] async: always set ctx->notified in aio_notify(), Stefan Hajnoczi, 2020/08/06
- Re: [PATCH v3 2/3] async: always set ctx->notified in aio_notify(),
Paolo Bonzini <=
- [PATCH v3 3/3] aio-posix: keep aio_notify_me disabled during polling, Stefan Hajnoczi, 2020/08/06
- Re: [PATCH v3 0/3] aio-posix: keep aio_notify_me disabled during polling, Paolo Bonzini, 2020/08/06
- Re: [PATCH v3 0/3] aio-posix: keep aio_notify_me disabled during polling, Stefan Hajnoczi, 2020/08/13