Re: [PATCH 4/4] trace-events: Fix attribution of trace points to source

[Philippe Mathieu-Daudé]

On 8/6/20 4:13 PM, Markus Armbruster wrote:
> Some trace points are attributed to the wrong source file.  Happens
> when we neglect to update trace-events for code motion, or add events
> in the wrong place, or misspell the file name.
> 
> Clean up with help of scripts/cleanup-trace-events.pl.  Funnies
> requiring manual post-processing:
> 
> * accel/tcg/cputlb.c trace points are in trace-events.
> 
> * block.c and blockdev.c trace points are in block/trace-events.
> 
> * hw/block/nvme.c uses the preprocessor to hide its trace point use
>   from cleanup-trace-events.pl.
> 
> * hw/tpm/tpm_spapr.c uses pseudo trace point tpm_spapr_show_buffer to
>   guard debug code.
> 
> * include/hw/xen/xen_common.h trace points are in hw/xen/trace-events.
> 
> * linux-user/trace-events abbreviates a tedious list of filenames to
>   */signal.c.
> 
> * net/colo-compare and net/filter-rewriter.c use pseudo trace points
>   colo_compare_miscompare and colo_filter_rewriter_debug to guard
>   debug code.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  block/trace-events        |  5 ++---
>  hw/block/trace-events     |  2 +-
>  hw/char/trace-events      |  2 +-
>  hw/display/trace-events   |  4 +++-
>  hw/hyperv/trace-events    |  2 +-
>  hw/mips/trace-events      |  2 +-
>  hw/misc/trace-events      |  8 +++++---
>  hw/ppc/trace-events       |  6 ++----
>  hw/riscv/trace-events     |  2 +-
>  hw/rtc/trace-events       |  2 +-
>  hw/tpm/trace-events       |  2 +-
>  hw/usb/trace-events       |  4 +++-
>  hw/vfio/trace-events      | 10 ++++++----
>  hw/virtio/trace-events    |  2 +-
>  migration/trace-events    | 36 +++++++++++++++++++-----------------
>  target/riscv/trace-events |  2 +-
>  trace-events              |  5 +++--
>  ui/trace-events           |  6 +++---
>  util/trace-events         |  4 +++-
>  19 files changed, 58 insertions(+), 48 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>