[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 005/143] meson: rename .inc.c files to .inc
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH 005/143] meson: rename .inc.c files to .inc |
|
Date: |
Fri, 7 Aug 2020 09:59:46 +0100 |
On Thu, 6 Aug 2020 at 20:25, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
What's the rationale for this ? ".inc.c" is the project's
standard naming convention for files which aren't headers
but which are lumps of C code #included into a top level .c
file. The .inc.c deliberately ends '.c' because that way
editors will use the right syntax highlighting for the file.
It would be much better if Meson could cope with our
standard naming convention rather than forcing us to change it.
thanks
-- PMM
- [PATCH 007/143] tests/vm: do not pollute configure with --efi-aarch64, (continued)
- [PATCH 007/143] tests/vm: do not pollute configure with --efi-aarch64, Paolo Bonzini, 2020/08/06
- [PATCH 008/143] tests/vm: check for Python YAML parser in the Makefile, Paolo Bonzini, 2020/08/06
- [PATCH 009/143] configure: do not include $(...) variables in config-host.mak, Paolo Bonzini, 2020/08/06
- [PATCH 004/143] trace: switch position of headers to what Meson requires, Paolo Bonzini, 2020/08/06
- [PATCH 010/143] configure: expand path variables for meson configure, Paolo Bonzini, 2020/08/06
- [PATCH 005/143] meson: rename .inc.c files to .inc, Paolo Bonzini, 2020/08/06
[PATCH 011/143] configure: prepare CFLAGS/CXXFLAGS/LDFLAGS for Meson, Paolo Bonzini, 2020/08/06
[PATCH 013/143] configure: generate Meson cross file, Paolo Bonzini, 2020/08/06
[PATCH 014/143] build-sys hack: link with whole .fa archives, Paolo Bonzini, 2020/08/06
[PATCH 015/143] build-sys: add meson submodule, Paolo Bonzini, 2020/08/06