[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.2] exec: Remove MemoryRegion::global_locking field
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH-for-5.2] exec: Remove MemoryRegion::global_locking field |
Date: |
Fri, 7 Aug 2020 12:16:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 |
On 07/08/20 12:02, Stefan Hajnoczi wrote:
> On Thu, Aug 06, 2020 at 05:07:26PM +0200, Philippe Mathieu-Daudé wrote:
>> Last uses of memory_region_clear_global_locking() have been
>> removed in commit 7070e085d4 ("acpi: mark PMTIMER as unlocked")
>> and commit 08565552f7 ("cputlb: Move NOTDIRTY handling from I/O
>> path to TLB path").
>> Remove memory_region_clear_global_locking() and the now unused
>> 'global_locking' field in MemoryRegion.
>>
>> Reported-by: Alexander Bulekov <alxndr@bu.edu>
>> Suggested-by: Stefan Hajnoczi <stefanha@redhat.com>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> include/exec/memory.h | 14 --------------
>> accel/tcg/cputlb.c | 4 ++--
>> exec.c | 2 +-
>> softmmu/memory.c | 6 ------
>> 4 files changed, 3 insertions(+), 23 deletions(-)
>
> It can be added back in later, if necessary. For now let's drop the dead
> code.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>
I expect it will come back since Linaro is working on BQL-free interrupt
handling for TCG, but no objections.
Paolo
signature.asc
Description: OpenPGP digital signature