[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 037/143] meson: add qemu-bridge-helper
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 037/143] meson: add qemu-bridge-helper |
Date: |
Fri, 7 Aug 2020 16:40:57 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 8/7/20 4:26 PM, Paolo Bonzini wrote:
> On 07/08/20 15:20, Philippe Mathieu-Daudé wrote:
>>> endif
>>>
>>> + if host_machine.system() == 'linux'
>>> + executable('qemu-bridge-helper', files('qemu-bridge-helper.c'),
>>> + dependencies: [qemuutil, libcap_ng],
>> Is libcap_ng still optional?
>>
>
> Yes, if a dependency is absent it is simply left out. See
> contrib/vhost-user-scsi for an example where the executable is disabled.
>
> Instead, if you want a dependency to be mandatory you have two choices:
>
> - to break the build you use "required: true", see the SDL conversion
> for an example
OK, good :)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> - to disable executables there is a thing called disabler but we're not
> using it because it's confusing. I was thinking of adding an
> "or_disable()" method to dependency objects, but I have never
> contributed it.
>
> Paolo
>
- [PATCH 032/143] contrib/elf2dmp: convert to meson, (continued)
- [PATCH 032/143] contrib/elf2dmp: convert to meson, Paolo Bonzini, 2020/08/06
- [PATCH 030/143] contrib/vhost-user-gpu: convert to meson, Paolo Bonzini, 2020/08/06
- [PATCH 034/143] meson: convert vss-win32, Paolo Bonzini, 2020/08/06
- [PATCH 031/143] contrib/ivshmem: convert to meson, Paolo Bonzini, 2020/08/06
- [PATCH 033/143] meson: convert qemu-ga, Paolo Bonzini, 2020/08/06
- [PATCH 035/143] meson: add msi generation, Paolo Bonzini, 2020/08/06
- [PATCH 036/143] meson: convert dummy Windows qga/qemu-ga target, Paolo Bonzini, 2020/08/06
- [PATCH 037/143] meson: add qemu-bridge-helper, Paolo Bonzini, 2020/08/06
- [PATCH 038/143] meson: add qemu-keymap, Paolo Bonzini, 2020/08/06
- [PATCH 039/143] meson: add qemu-edid, Paolo Bonzini, 2020/08/06
- [PATCH 040/143] meson: add virtfs-proxy-helper, Paolo Bonzini, 2020/08/06
- [PATCH 041/143] meson: keymap-gen, Paolo Bonzini, 2020/08/06
- [PATCH 042/143] meson: generate qemu-version.h, Paolo Bonzini, 2020/08/06
- [PATCH 043/143] meson: generate shader headers, Paolo Bonzini, 2020/08/06
- [PATCH 044/143] meson: generate hxtool files, Paolo Bonzini, 2020/08/06
- [PATCH 045/143] meson: uncompress edk2 bios, Paolo Bonzini, 2020/08/06