[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC
From: |
Babu Moger |
Subject: |
[PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC |
Date: |
Fri, 07 Aug 2020 11:32:51 -0500 |
User-agent: |
StGit/unknown-version |
Adding a new check to warn the users to configure 'dies' when
topology is numa configured. It makes it easy to build the
topology for EPYC models.
Signed-off-by: Babu Moger <babu.moger@amd.com>
---
hw/i386/x86.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/hw/i386/x86.c b/hw/i386/x86.c
index 67bee1bcb8..2a6ce56ef1 100644
--- a/hw/i386/x86.c
+++ b/hw/i386/x86.c
@@ -138,6 +138,13 @@ void x86_cpus_init(X86MachineState *x86ms, int
default_cpu_version)
/* Check for apicid encoding */
if (cpu_x86_use_epyc_apic_id_encoding(ms->cpu_type)) {
+ if ((ms->numa_state->num_nodes > 0) &&
+ ms->numa_state->num_nodes != (ms->smp.sockets * x86ms->smp_dies)) {
+ error_setg(&error_fatal, "Numa configuration requires smp 'dies' "
+ "parameter. Configure the cpu topology properly with "
+ "max_cpus = sockets * dies * cores * threads");
+ return;
+ }
x86_set_epyc_topo_handlers(ms);
}
- [PATCH v3 0/3] Fix couple of issues with AMD topology, Babu Moger, 2020/08/07
- [PATCH v3 1/3] i386: Simplify CPUID_8000_001E for AMD, Babu Moger, 2020/08/07
- [PATCH v3 3/3] hw/i386: Remove node_id, nr_nodes and nodes_per_pkg from topology, Babu Moger, 2020/08/07
- [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC,
Babu Moger <=
- Re: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC, Daniel P . Berrangé, 2020/08/07
- Re: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC, Babu Moger, 2020/08/07
- Re: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC, Igor Mammedov, 2020/08/07
- Re: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC, Babu Moger, 2020/08/11
- Re: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC, Igor Mammedov, 2020/08/13
- RE: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC, Babu Moger, 2020/08/13
Re: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC, Igor Mammedov, 2020/08/07