[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] acceptance: update asset hashes for the Bionic aarch64 insta
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] acceptance: update asset hashes for the Bionic aarch64 installer |
|
Date: |
Mon, 10 Aug 2020 11:35:22 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 8/10/20 11:24 AM, Paolo Bonzini wrote:
> On 10/08/20 11:06, Philippe Mathieu-Daudé wrote:
>> The 'bug' is this link is using "current" which will be a problem each
>> time Ubuntu update the installer (latest update was last Wed, Aug 5).
>>
>> Acceptance tests should be stick to a particular set of binary, knew to
>> have worked once in the past. If a new set works, I'd rather see a new
>> test added (because it might have a different QEMU coverage).
>
> That seems overkill but yeah the tests should have used
> 20101020ubuntu543.15 instead of current. I think this should get into rc4.
As our CI is not yet gating, I don't think this justifies delaying the
release (except if there is a critical bugfix on the list).
Maybe it is acceptable to simply merge the CI test fixes before the
release tag, as no code/binary is affected...
>
> Paolo
>