On Mon, 10 Aug 2020 at 20:49, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 10/08/20 21:45, Peter Maydell wrote:
> >> Note that if you don't install it, you just get the previous behavior
> >> (plus a warning). But if you want that, it would be simply "gettext" I
> >> guess. You're using tests/vm/*bsd right?
> > Yes. Unless there's a strong reason for testing the no-gettext
> > configuration via the BSD VMs it seems like we might as well
> > just install the dependency. Silencing the warning would be
> > nice as well if the lack of it isn't actually problematic.
> >
>
> No, I think the warning is valid. Silencing it would be predicated on
> --disable-gettext or something like that. I'll just add the dependency.
Our usual default convention is "if the host system has feature X,
act as if --enable-X, otherwise act as if --disable-X", not
"act as if --disable-X apart from warning about it".
Fair enough. Actually Meson has the same concept of enabled/auto/disabled features so it would have been nice to just add a required option to i18n.gettext. I will just open code it to avoid waiting for the next release.
Paolo