[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 01/14] replay: don't record interrupt poll
From: |
Pavel Dovgalyuk |
Subject: |
[PATCH v2 01/14] replay: don't record interrupt poll |
Date: |
Tue, 11 Aug 2020 14:00:59 +0300 |
User-agent: |
StGit/0.17.1-dirty |
Interrupt poll is not a real interrupt event. It is needed only for
thread safety. This interrupt is used for i386 and converted
to hardware interrupt by cpu_handle_interrupt function.
Therefore it is not needed to be recorded, because hardware
interrupt will be recorded after converting.
Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
---
accel/tcg/cpu-exec.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
index 66d38f9d85..28aff1bb1e 100644
--- a/accel/tcg/cpu-exec.c
+++ b/accel/tcg/cpu-exec.c
@@ -429,8 +429,7 @@ static inline bool cpu_handle_halt(CPUState *cpu)
{
if (cpu->halted) {
#if defined(TARGET_I386) && !defined(CONFIG_USER_ONLY)
- if ((cpu->interrupt_request & CPU_INTERRUPT_POLL)
- && replay_interrupt()) {
+ if (cpu->interrupt_request & CPU_INTERRUPT_POLL) {
X86CPU *x86_cpu = X86_CPU(cpu);
qemu_mutex_lock_iothread();
apic_poll_irq(x86_cpu->apic_state);
@@ -587,7 +586,13 @@ static inline bool cpu_handle_interrupt(CPUState *cpu,
and via longjmp via cpu_loop_exit. */
else {
if (cc->cpu_exec_interrupt(cpu, interrupt_request)) {
- replay_interrupt();
+ if (true
+#if defined(TARGET_I386)
+ && !(interrupt_request & CPU_INTERRUPT_POLL)
+#endif
+ ) {
+ replay_interrupt();
+ }
/*
* After processing the interrupt, ensure an EXCP_DEBUG is
* raised when single-stepping so that GDB doesn't miss the
- [PATCH v2 00/14] Reverse debugging, Pavel Dovgalyuk, 2020/08/11
- [PATCH v2 01/14] replay: don't record interrupt poll,
Pavel Dovgalyuk <=
- [PATCH v2 02/14] replay: provide an accessor for rr filename, Pavel Dovgalyuk, 2020/08/11
- [PATCH v2 03/14] qcow2: introduce icount field for snapshots, Pavel Dovgalyuk, 2020/08/11
- [PATCH v2 04/14] migration: introduce icount field for snapshots, Pavel Dovgalyuk, 2020/08/11
- [PATCH v2 05/14] iotests: update snapshot test for new output format, Pavel Dovgalyuk, 2020/08/11
- [PATCH v2 06/14] qapi: introduce replay.json for record/replay-related stuff, Pavel Dovgalyuk, 2020/08/11
- [PATCH v2 07/14] replay: introduce info hmp/qmp command, Pavel Dovgalyuk, 2020/08/11
- [PATCH v2 08/14] replay: introduce breakpoint at the specified step, Pavel Dovgalyuk, 2020/08/11
- [PATCH v2 09/14] replay: implement replay-seek command, Pavel Dovgalyuk, 2020/08/11
- [PATCH v2 10/14] replay: flush rr queue before loading the vmstate, Pavel Dovgalyuk, 2020/08/11
- [PATCH v2 11/14] gdbstub: add reverse step support in replay mode, Pavel Dovgalyuk, 2020/08/11