Re: [PATCH] hw/vfio/pci-quirks: Fix broken legacy IGD passthrough

[Philippe Mathieu-Daudé]

On Wed, Jun 10, 2020 at 3:17 PM Laurent Vivier <laurent@vivier.eu> wrote:
> Le 10/06/2020 à 09:50, Thomas Huth a écrit :
> > On 10/06/2020 09.31, Philippe Mathieu-Daudé wrote:
> >> On 6/10/20 5:51 AM, Thomas Huth wrote:
> >>> The #ifdef CONFIG_VFIO_IGD in pci-quirks.c is not working since the
> >>> required header config-devices.h is not included, so that the legacy
> >>> IGD passthrough is currently broken. Let's include the right header
> >>> to fix this issue.
> >>>
> >>> Buglink: https://bugs.launchpad.net/qemu/+bug/1882784
> >>> Fixes: 29d62771c81d8fd244a67c14a1d968c268d3fb19
> >>>        ("hw/vfio: Move the IGD quirk code to a separate file")
> >>
> >> What about shorter tag?
> >>
> >> Fixes: 29d62771c81 ("vfio: Move the IGD quirk code to a separate file")
> >
> > I always forget whether to use the short or the long version for
> > "Fixes:" ... this can hopefully be fixed (if necessary) when the patch
> > gets picked up.
>
> you can add in your ~/.gitconfig
>
> [alias]
>         showfix = log -1 --format=fixes
> [pretty]
>         fixes = Fixes: %h (\"%s\")%nCc: %ae

>From git-show (1):

           ·   %ae: author email
           ·   %aE: author email (respecting .mailmap, see
git-shortlog(1) or git-blame(1))

Since we have .mailmap, the %aE form is highly recommended:

With %ae:
$ git showfix 3e3d5815cbc1fdbf33adbe55f63ede3acead886f
Fixes: 3e3d5815cb ("NAND Flash memory emulation and ECC calculation
helpers for use by NAND controllers.")
Cc: balrog@c046a42c-6fe2-441c-8c8c-71466251a162

With %aE:
$ git showfix 3e3d5815cbc1fdbf33adbe55f63ede3acead886f
Fixes: 3e3d5815cb ("NAND Flash memory emulation and ECC calculation
helpers for use by NAND controllers.")
Cc: balrogg@gmail.com

>
> and then:
>
> $ git showfix 29d62771c81d8fd244a67c14a1d968c268d3fb19
> Fixes: 29d62771c81d ("hw/vfio: Move the IGD quirk code to a separate file")
>
> Thanks,
> Laurent
>