[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.2 4/4] hw/char/serial: Use the Clock API to feed the UA
From: |
Richard Henderson |
Subject: |
Re: [PATCH-for-5.2 4/4] hw/char/serial: Use the Clock API to feed the UART reference clock |
Date: |
Wed, 12 Aug 2020 10:46:42 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 8/6/20 6:03 AM, Philippe Mathieu-Daudé wrote:
> In the same chipset, UARTs can be clocked at different rate, or the
> input clock can be changed at runtime. The Clock API allow us to
> propagate such clock rate change to the device.
> Let the SerialState have its reference input clock (called 'rclk')
> and if not clock is connected to the device, use the currently provided
s/not/no/
> frequency, to not modify the current code behavior.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/hw/char/serial.h | 3 +++
> hw/char/serial.c | 35 ++++++++++++++++++++++++++++-------
> 2 files changed, 31 insertions(+), 7 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- [PATCH-for-5.2 0/4] hw/char/serial: Use the Clock API to feed the UART reference clock, Philippe Mathieu-Daudé, 2020/08/06
- [PATCH-for-5.2 2/4] hw/char/serial: Remove old DEBUG_SERIAL commented code, Philippe Mathieu-Daudé, 2020/08/06
- [PATCH-for-5.2 3/4] hw/char/serial: Let SerialState have an 'id' field, Philippe Mathieu-Daudé, 2020/08/06
- [PATCH-for-5.2 1/4] hw/char/serial: Replace commented DPRINTF() by trace event, Philippe Mathieu-Daudé, 2020/08/06
- [PATCH-for-5.2 4/4] hw/char/serial: Use the Clock API to feed the UART reference clock, Philippe Mathieu-Daudé, 2020/08/06
- Re: [PATCH-for-5.2 4/4] hw/char/serial: Use the Clock API to feed the UART reference clock,
Richard Henderson <=
- Re: [PATCH-for-5.2 0/4] hw/char/serial: Use the Clock API to feed the UART reference clock, Philippe Mathieu-Daudé, 2020/08/22